init.pp: Add missing datatypes #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
force-pushed
the
types
branch
5 times, most recently
from
16a552a to
07cf3d4
Compare
alexjfisher
reviewed
Jun 28, 2023
alexjfisher
reviewed
Jun 28, 2023
alexjfisher
reviewed
Jun 28, 2023
alexjfisher
reviewed
Jul 5, 2023
Allow raw integers and add support for combination of multiple units.
smortex
force-pushed
the
types
branch
3 times, most recently
from
9dd63ad to
e8c4185
Compare
Some parameter data types are not great and deserve to be changed. Use Variant to allow both the old and new data types, but emit a deprecation warning if the legacy data type is used. A future backward-incompatible PR will remove these legacy data-types and the deprecation warnings.
|
FYI, a companion PR was opened in #1566 to remove the compatibility data types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues